ENH: Air brakes controller functions now support 8-parameter signature #854
+532
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@MateusStano could you review this one please? |
There was a problem hiding this comment.
Pull Request Overview
This PR solves the issue where air brake controllers relied on global environment variables by adding an environment parameter to the controller function signature. This enables local access to atmospheric conditions without using global variables.
- Added environment parameter support to controller functions (6, 7, or 8 parameters now supported)
- Updated controller initialization to handle the new environment parameter with backward compatibility
- Created test fixtures and standalone test script to demonstrate the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/fixtures/function/function_fixtures.py | Added new test fixture demonstrating environment parameter usage in controller |
| test_environment_parameter.py | Standalone test script showing different controller signatures and environment usage |
| rocketpy/simulation/flight.py | Updated simulation to pass environment parameter to controllers |
| rocketpy/rocket/rocket.py | Updated documentation to describe the new environment parameter |
| rocketpy/control/controller.py | Enhanced controller initialization to support 8-parameter functions and updated call signature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Gui-FernandesBR
force-pushed
the
env_localise
branch
from
a3b63dc to
436080f
Compare
Gui-FernandesBR
force-pushed
the
env_localise
branch
from
436080f to
9505f3c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #854 +/- ##
===========================================
+ Coverage 80.27% 80.37% +0.10%
===========================================
Files 104 106 +2
Lines 12769 13013 +244
===========================================
+ Hits 10250 10459 +209
- Misses 2519 2554 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gui-FernandesBR
force-pushed
the
env_localise
branch
from
9505f3c to
a8abae4
Compare
Gui-FernandesBR
changed the title
…d improve environment access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCurrent behavior
here, air brakes controller doesn't pass environment as parameter but uses the global variables.
New behavior
Now, air brakes controller uses env parameter, you can use the file "test_environment_parameter.py" to check functioning.
Breaking change
Additional information
Enter text here...